Centralize command-line parsing #2412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slackpad
reviewed
Oct 27, 2016
| name string | ||
| passStdin bool | ||
| timeout time.Duration | ||
| verbose bool | ||
| } | ||
|
|
||
| func (c *LockCommand) Help() string { | ||
| helpText := ` |
There was a problem hiding this comment.
Did you consider putting the intro text into the meta object as well and then you'd just return c.Meta.Help() here? If we had markdown in here we could strip it for the CLI and generate the web versions with some magic :-)
|
@kyhavlov the todo "Don't print out help output on flag failure (the failure is way at the top and the help output often scrolls beyond)" is worth keeping track of - that's actually pretty bad rn because the error is always at the top of a bunch of stuff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔴 Early POC 🔴
This is a fairly large, but localized refactor to attempt to centralize our CLI parsing options and output. It adds a
Metastruct that is aware of common information and includes functions for generating an HTTP/RPC client and the associated CLI flags. It also has logic on how to pretty-print flags, wrap to a specified line length, and more.TODO
/cc @slackpad for early review.